Skip to content

[UTEST][SDIO] Add block device read and write test - #11758

Open
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:test/sdio-block-read-write
Open

[UTEST][SDIO] Add block device read and write test#11758
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:test/sdio-block-read-write

Conversation

@CYFS3

@CYFS3 CYFS3 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

当前缺少不依赖 DFS 的 SDIO 链路读写测试，无法直接验证 utest 到 block、MMCSD 和 SDHI 驱动的完整数据通路。

你的解决方案是什么 (what is your solution)

新增可配置的 SDIO block utest，对整盘设备执行 geometry 检查、单扇区读写、起始和末尾多扇区读写，以及关闭重开后的数据回读，并逐字节比较写入与读取内容。测试会覆盖配置范围内的原扇区数据；已在 RA8D1 配置下编译测试对象通过。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支（通常为 master）
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 test/sdio-block-read-write
    Enter PR branch test/sdio-block-read-write in the branch field
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 test/sdio-block-read-write 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the test/sdio-block-read-write branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/sdio/utest/Kconfig
  • components/drivers/sdio/utest/SConscript
  • components/drivers/sdio/utest/sdio_read_write_tc.c
  • components/utilities/utest/Kconfig

📊 Current Review Status (Last Updated: 2026-08-27 14:05 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@CYFS3 CYFS3 mentioned this pull request Aug 26, 2026
Open
34 tasks
@github-actions

github-actions Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

k230

  • SRAM: .text +64 B (+0.0%, 1,123,067 B / 268,300,288 B, total: 0% used)

nuvoton-m487

  • CODE: .text +84 B (+0.0%, 356,016 B / 524,288 B, total: 68% used)

simulator

kurisaW
kurisaW reviewed Aug 27, 2026
View reviewed changes
Comment thread components/drivers/sdio/utest/sdio_read_write_tc.c Outdated
*
* Change Logs:
* Date Author Notes
* 2026-08-26 Codex add SDIO block read and write utest

@kurisaW kurisaW Aug 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块建议用个人id吧

@kurisaW

kurisaW commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

drivers/uetst重点聚焦驱动框架的测试，是不是考虑使用驱动框架API进行覆盖测试，而不是上层设备ops

@kurisaW kurisaW added the -1 No vote label Aug 27, 2026
@CYFS3

CYFS3 commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

关于测试接口的说明：
SD 存储卡的块读写在 RT-Thread 中由 MMCSD + block 框架承载，当前没有独立的公开 sdio_read/sdio_write API。mmcsd_send_cmd() / mmcsd_send_request() 是底层命令与请求接口，直接在 utest 中重写块读写流程会重复 components/drivers/sdio/dev_block.c 的实现，并绕过 block 设备的注册、打开和关闭流程。
因此本测试通过已注册的 SD block 设备验证 geometry、块读写和关闭重开后的数据持久性，覆盖路径为 utest -> block framework -> MMCSD -> SDHI。若要求直接调用 block framework 的
t_blk_disk_ops，当前公开 API 没有对应的 read/write 包装函数，需要先在 block 框架增加正式 API；直接从 utest 访问内部 ops 会绕过框架锁和只读检查。

@kurisaW kurisaW removed the -1 No vote label Aug 27, 2026
@kurisaW

kurisaW commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

components/drivers/utest更倾向于驱动框架的API覆盖测试，也就是某一驱动的单元测试，重点要求API的覆盖以及功能链路的验证，这块考虑一下回归单元测试的本质吧，后面也可以一起讨论下形式

@CYFS3

CYFS3 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

st() 是底层命令与请求接口，直接在 utest 中重写块读写流程会重复 components/drivers/sdio/dev_block.c 的实现，并绕过 block 设备的注册、打开和关闭流程。
因此本测试通过已注册的 SD block 设备验证 geometry、块读写和关闭重开后的数据持久性，覆盖路径为 utest -> block framework -> MMCSD -> SDHI。若要求直接调用 block framework 的
t_blk_disk_ops，当前公开 API 没有对应的 read/write 包装函数，需要先在 block 框架增加正式 API；直接从 utest 访问内部 ops 会绕过框架锁和只读检查。

这个可以讨论一下吧，因为现用的serial_v2其实也是用了io管理层的api。驱动类 utest 的重点是验证具体 BSP 对驱动框架的适配是否正确。因此，测试用例更倾向于模拟用户或应用层的实际使用方式。然后rt_device_xx本质上也是调用驱动层的api。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kurisaW kurisaW kurisaW approved these changes

Assignees

No one assigned

Labels

component: drivers/sdio component: drivers Component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CYFS3 @kurisaW